issue_comments: 494151339

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2956#issuecomment-494151339 https://api.github.com/repos/pydata/xarray/issues/2956 494151339 MDEyOklzc3VlQ29tbWVudDQ5NDE1MTMzOQ== 14808389 2019-05-20T21:07:06Z 2019-05-20T21:07:06Z MEMBER

I added the option, though the documentation is minimal. It gets used by a function to decide between asarray and asanyarray, and this function is then called in as_compatible_data and in the Variable.data property. Also, .mean() did not work before because duck_array_ops.asarray used np.asarray, which I replaced with that switching function. Should I test more of these reduce functions (if so, which)?

The matrix class gets treated similar to MaskedArray, and the unittests prove that enabling subclass support does not work for these two.

Is the failure of the docs related to any of the changes I made?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   443157666