issue_comments: 494062757

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2706#issuecomment-494062757 https://api.github.com/repos/pydata/xarray/issues/2706 494062757 MDEyOklzc3VlQ29tbWVudDQ5NDA2Mjc1Nw== 1197350 2019-05-20T16:38:24Z 2019-05-20T16:38:24Z MEMBER

Hi @davidbrochart. I'm really sorry it takes me so long between reviews of your PR. It is very important work, and I appreciate your continued patience.

I looked at your new code, and I noticed that chunk_dim does not appear in the tests. I think it is important to test this parameter and verify that it works as expected. (This would also help me understand how it works, since it's not totally clear from the docs.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   402908148