home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 493782708

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2972#issuecomment-493782708 https://api.github.com/repos/pydata/xarray/issues/2972 493782708 MDEyOklzc3VlQ29tbWVudDQ5Mzc4MjcwOA== 1217238 2019-05-19T19:04:42Z 2019-05-19T19:04:42Z MEMBER

I'm not entirely sure this is a good idea -- a discrepancy in the behavior of an outer join between pandas seems non-ideal. Perhaps somebody else has opinions about whether this would be worthwhile?

If we do want to do this, let's put the change inside the _get_joiner function. Specifically, instead of python def _get_joiner(join): if join == 'outer': return functools.partial(functools.reduce, operator.or_) you could write something like: ```python def outer_join(indexes): index = functools.reduce(indexes, operator.or) # your logic for reverse sorting the result return index

def _get_joiner(join): if join == 'outer': return _outer_join ```

Note that operator.or_ on a pandas.Index is the same thing as pandas.Index.union, so this could be equivalently written (maybe more clearly) as: python def _outer_join(indexes): index = indexes[0] for other in indexes[1:] index = index.union(other) # your logic for reverse sorting the result return index

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  445745470
Powered by Datasette · Queries took 0.662ms · About: xarray-datasette