issue_comments: 490434825

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2948#issuecomment-490434825 https://api.github.com/repos/pydata/xarray/issues/2948 490434825 MDEyOklzc3VlQ29tbWVudDQ5MDQzNDgyNQ== 10194086 2019-05-08T10:29:09Z 2019-05-08T10:29:09Z MEMBER

Yes, you are right - I did not take the Iterable[...] part in the docs seriously enough.

Would it make sense to pack them?

python if isinstance(objects, (xr.DataArray, xr.Dataset, dict)): objects = [objects] Because the alternative is to raise and then the user has to do [objects] himself, which seems a bit nonsensical to me. Although it is also nonsensical to pass a single DataArray or a Dataset to xr.merge, in contrast to dict.

Then we would need to check isinstance(obj, (xr.DataArray, xr.Dataset, dict)) in the in the dict_like_objects-loop and if not raise a ValueError?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   441341354