issue_comments: 488031173

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2922#issuecomment-488031173 https://api.github.com/repos/pydata/xarray/issues/2922 488031173 MDEyOklzc3VlQ29tbWVudDQ4ODAzMTE3Mw== 10194086 2019-04-30T16:57:05Z 2019-04-30T16:57:05Z MEMBER

I updated the PR * added a weighted sum method * tried to clean the tests

Before I continue, it would be nice to get some feedback.

  • Currently I only do very simple tests - is that enough? How could these be generalized without re-implementing the functions to obtain expected.
  • Eventually it would be cool to be able to do da.groupby(regions).weighted(weights).mean() - do you see a possibility for this with the current implementation?

As mentioned by @aaronspring, esmlab already implemented weighted statistic functions. Similarly, statsmodels for 1D data without handling of NaNs (docs / code). Thus it should be feasible to implement further statistics here (weighted std).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   437765416