issue_comments: 485210441

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1809#issuecomment-485210441 https://api.github.com/repos/pydata/xarray/issues/1809 485210441 MDEyOklzc3VlQ29tbWVudDQ4NTIxMDQ0MQ== 4133310 2019-04-21T01:09:04Z 2019-04-24T19:24:02Z NONE

I ran into this issue trying to roundtrip a WRF output file. It looks like xarray raises an error for any NetCDF file that has variables with a coordinates attribute:

python # These coordinates are saved according to CF conventions for var_name, coord_names in variable_coordinates.items(): attrs = variables[var_name].attrs if 'coordinates' in attrs: raise ValueError('cannot serialize coordinates because variable ' "%s already has an attribute 'coordinates'" % var_name) attrs['coordinates'] = ' '.join(map(str, coord_names))

~~Both this choice, and the proposed solution in this issue (delete all coordinates attributes), I don't understand.~~ Variables with a coordinates attribute are CF conforming, so xarray should be able to play along with this.

~~The solution that makes more sense to me is to raise a warning and overwrite or ignore the coordinates attribute, if the attribute is already present. Later step of the fix could even be a keyword argument to allow the user to choose whether to overwrite or ignore "conflicting" attributes.~~

Or perhaps I'm missing something obvious here... Let me know either way. I'd be happy to make a PR to patch this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   286072335