issue_comments: 484234275

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2904#issuecomment-484234275 https://api.github.com/repos/pydata/xarray/issues/2904 484234275 MDEyOklzc3VlQ29tbWVudDQ4NDIzNDI3NQ== 5635139 2019-04-17T19:45:48Z 2019-04-17T19:45:48Z MEMBER

I feel like it is widely accepted that in the scientific Python ecosystem error messages are hard to read quite often. Maybe this is the downside the duck typing?

We can make it better! While duck typing does allow passing incorrectly typed arguments, it doesn't prevent us from checking their types. Python now has types like Mapping or Sized which can be used more like protocols and so don't give up flexibility. So I think it would be strictly dominant for us to check for an instance of Mapping there, and raise a readable error message if it fails.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   434444058