issue_comments: 481739493
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/2877#issuecomment-481739493 | https://api.github.com/repos/pydata/xarray/issues/2877 | 481739493 | MDEyOklzc3VlQ29tbWVudDQ4MTczOTQ5Mw== | 6213168 | 2019-04-10T15:29:04Z | 2019-04-10T15:29:04Z | MEMBER | @shoyer I changed dimensions from str to Hashable as requested. In my opinion however it's not great, because 1. it's currently thoroughly broken due to lack of unit tests 2. it weakens type checking a lot, since Tuple is a subclass of Hashable however the vast majority of xarray functions deal with tuples with a specific code branch Please review again - in theory, common.py and util.py are now 100% done. They pass flake8 and mypy (on python 3.7). If you like them please go on and merge into Master; since the work that needs to be done is going to touch literally everything I think it's best to break it down into more manageable chunks. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
430214243 |