home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 481227438

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2879#issuecomment-481227438 https://api.github.com/repos/pydata/xarray/issues/2879 481227438 MDEyOklzc3VlQ29tbWVudDQ4MTIyNzQzOA== 6628425 2019-04-09T12:19:01Z 2019-04-09T12:19:01Z MEMBER

Thanks for having a look @jwenfai! I updated my PR following your suggestions; this added some more tests so now the total time is around 9 seconds.

I opted for listing the pairs of initial and resample frequencies explicitly rather than use a function to dynamically set one based on the other (I feel like it makes the tests easier to understand; also writing a function that converts one type of frequency to another similar-length-but-different-type frequency is messy).

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  430460404
Powered by Datasette · Queries took 2.907ms · About: xarray-datasette