issue_comments: 480767658

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2877#issuecomment-480767658 https://api.github.com/repos/pydata/xarray/issues/2877 480767658 MDEyOklzc3VlQ29tbWVudDQ4MDc2NzY1OA== 6213168 2019-04-08T10:01:26Z 2019-04-08T10:01:26Z MEMBER

@shoyer I have a problem. In Python 3.5.0-3.5.2, to create a custom typed collection you have to write class Frozen(collections.abc.Mapping, typing.Mapping[K, V]): Whereas in Python >= 3.5.3, you must just write class Frozen(typing.Mapping[K, V]): Things won't work if you use the < 3.5.3 syntax.

As an unrelated note, I'm observing that if I set python=3.5.3 in ci/requirements-py35.yml, a ton of unit tests fall apart. The test suite ci/requirements-py35-min.yml ensures compatibility with Python 3.5.0... but only as long as you don't use any of the non-mandatory dependencies. Can we 1) increase the minimum requirements to 3.5.4 and 2) set python=3.5.4 in ci/requirements-py35.yml? Is there a roadmap for dropping 3.5 entirely? (conda-forge already did...) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   430214243