home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 480624904

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2871#issuecomment-480624904 https://api.github.com/repos/pydata/xarray/issues/2871 480624904 MDEyOklzc3VlQ29tbWVudDQ4MDYyNDkwNA== 1217238 2019-04-07T20:11:05Z 2019-04-07T20:11:05Z MEMBER

Indeed it works. Thanks. My quick fix:

$ diff variables.py variables.py.orig 152,155d151 < elif encoding.get('missing_value') is not None: < fill_value = pop_to(encoding, attrs, 'missing_value', name=name) < if not pd.isnull(fill_value): < data = duck_array_ops.fillna(data, fill_value) I also figured out how to write back floating point values: encoding=None means use existing values, so specifying encoding={'tmpk': {}} in to_netcdf() did the trick. Should there be an option for this? What you see on the screen is not what you get in the file.

Yes, this is a challenging design problem and the current state of affairs is definitely not ideal. If you have ideas about how to reveal the presence of an encoding dict associated with a variable without overwhelming the user with information those would be very welcome. The alternative would be to not keep around encoding at all, but I think users do appreciate that reading/writing a netCDF file generally returns the exact same thing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  429914958
Powered by Datasette · Queries took 0.849ms · About: xarray-datasette