home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 480071693

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2858#issuecomment-480071693 https://api.github.com/repos/pydata/xarray/issues/2858 480071693 MDEyOklzc3VlQ29tbWVudDQ4MDA3MTY5Mw== 1217238 2019-04-04T21:32:27Z 2019-04-04T21:32:27Z MEMBER

I did look at the index invariant tests with more detail, and they look

Yes, this is the main part I was hoping for someone to take a look at. I would not trust my fixes if I did not believe the tests :).

The rest of it are various smaller changes, mostly correcting my previously mistaken (and untested) implementations.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  427451138
Powered by Datasette · Queries took 0.64ms · About: xarray-datasette