home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 479931557

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2858#issuecomment-479931557 https://api.github.com/repos/pydata/xarray/issues/2858 479931557 MDEyOklzc3VlQ29tbWVudDQ3OTkzMTU1Nw== 5635139 2019-04-04T14:54:56Z 2019-04-04T14:54:56Z MEMBER

I had a look through the code. I'm struggling a bit to be a good reviewer given my current understanding of how the goals connect to to the implementation. With that disclaimer, the code looks good. So if anyone knows this better, maybe have a look. I did look at the index invariant tests with more detail, and they look 👍

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  427451138
Powered by Datasette · Queries took 0.665ms · About: xarray-datasette