issue_comments: 479831812

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2751#issuecomment-479831812 https://api.github.com/repos/pydata/xarray/issues/2751 479831812 MDEyOklzc3VlQ29tbWVudDQ3OTgzMTgxMg== 971382 2019-04-04T09:55:14Z 2019-04-04T09:55:14Z NONE

@shoyer sorry for the delayed response. dtypes.result_type(1, np.float32(1)) returns dtype('float64') That's what makes this behaviour for Python's int and float Keeping the consistency would then require testing if scale_factor*var_dtype + add_offset fit in var_dtype in case of Python's int and float. Correct me if i'm wrong but this is a bit hard to do without knowing max,min values to avoid overlapping Evaluating those could break performance if only used for encoding and decoding. Do have any idea how this could be acheived ? or is it simpler to keep it as it is ? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   407746874