home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 469089587

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2616#issuecomment-469089587 https://api.github.com/repos/pydata/xarray/issues/2616 469089587 MDEyOklzc3VlQ29tbWVudDQ2OTA4OTU4Nw== 35968931 2019-03-04T01:34:25Z 2019-03-04T01:34:25Z MEMBER

I think that manual_combine and auto_combine (or combine_auto etc.) are pretty suitable.

Any variation on concat is a little misleading because these functions will also merge. Anything with nested or multi is kind of superfluous when the idea of the library is sort of that multi-dimensional operations are as easy as single-dimensional operations.

combine (dictionary definition: to join or merge to form a single unit or substance) does accurate describe what the functions do.

If we use combine_auto and combine_manual then it simplifies the deprecation cycle because we can have the old auto_combine and the new combine_auto in the API simultaneously (though maybe that's too confusing).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  391865060
Powered by Datasette · Queries took 0.632ms · About: xarray-datasette