issue_comments: 469019590

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2616#issuecomment-469019590 https://api.github.com/repos/pydata/xarray/issues/2616 469019590 MDEyOklzc3VlQ29tbWVudDQ2OTAxOTU5MA== 35968931 2019-03-03T12:46:08Z 2019-03-03T12:46:08Z MEMBER

Okay @shoyer so the way I've gone about this deprecation problem is to essentially introduce manual_combine whilst reverting auto_combine. That means that auto_combine isn't a breaking change yet, but it's inputs are checked and if they will break in future it throws a warning saying "please use manual_combine instead because the behaviour of auto_combine will soon change".

This way we don't have two publicly-accessible versions of auto_combine present simultaneously, and if users heed the warnings and switch to using manual_combine then their code won't break when we later update auto_combine from the old to the new behaviour.

This approach means there currently isn't a way to opt-in to the new auto_combine behaviour early, but as you can opt-in to future-compatible behaviour by using manual_combine instead, then I think that's fine?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   391865060