issue_comments: 466463669

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2767#issuecomment-466463669 https://api.github.com/repos/pydata/xarray/issues/2767 466463669 MDEyOklzc3VlQ29tbWVudDQ2NjQ2MzY2OQ== 223250 2019-02-22T16:47:11Z 2019-02-22T16:47:11Z CONTRIBUTOR

I agree that it makes sense to recompute dimensions from variables.

Okay, that's what this PR already did (via the call to _replace_with_new_dims).

Rebased on master. From my perspective, this should be good to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   409618228