issue_comments: 466239515

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2767#issuecomment-466239515 https://api.github.com/repos/pydata/xarray/issues/2767 466239515 MDEyOklzc3VlQ29tbWVudDQ2NjIzOTUxNQ== 1217238 2019-02-22T01:41:41Z 2019-02-22T01:41:41Z MEMBER

It's OK to use _replace_with_new_dims still. I think we'll eventually replace it in favor of _replace_with_new_dims but we aren't there yet.

I agree that it makes sense to recompute dimensions from variables. There's not much point in keeping around extra dimensions that don't have corresponding variables, and I'm pretty sure that this is consistent with how Dataset.drop() works.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   409618228