issue_comments: 464257620

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2766#issuecomment-464257620 https://api.github.com/repos/pydata/xarray/issues/2766 464257620 MDEyOklzc3VlQ29tbWVudDQ2NDI1NzYyMA== 1217238 2019-02-16T00:14:28Z 2019-02-16T00:14:28Z MEMBER

Yes, we'll want to add our own wrapper functions. (Or possibly a new apply() method could do the dim -> axis renaming)

On Fri, Feb 15, 2019 at 4:01 PM Maximilian Roos notifications@github.com wrote:

Yes, np.pinv will raise if passed a dim kwargs. This was an intentional choice: http://www.numpy.org/neps/nep-0018-array-function-protocol.html#support-for-implementation-specific-arguments

Thanks.

With the current state, am I correct in thinking we still need wrappers for any numpy.linalg function that requires a dim kwarg? (I guess we could use the axis kwarg instead, but that might be confusing things)

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2766#issuecomment-464254541, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gNtPViHaVR_wyopKAktKCHgztfUks5vN0phgaJpZM4a4kfe . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   409618015