issue_comments: 462614107

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2304#issuecomment-462614107 https://api.github.com/repos/pydata/xarray/issues/2304 462614107 MDEyOklzc3VlQ29tbWVudDQ2MjYxNDEwNw== 1217238 2019-02-12T04:46:18Z 2019-02-12T04:46:47Z MEMBER

@magau thanks for pointing this out -- I think we simplify missed this part of the CF conventions document!

Looking at the dtype for add_offset and scale_factor does seem like a much cleaner way to handle this issue. I think we should give that a try!

We will still need some fall-back choice for CFMaskCoder if neither a add_offset or scale_factor attribute is provided (due to xarray's representation of missing values as NaN), but this is a relatively uncommon situation.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   343659822