issue_comments: 461856173

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2751#issuecomment-461856173 https://api.github.com/repos/pydata/xarray/issues/2751 461856173 MDEyOklzc3VlQ29tbWVudDQ2MTg1NjE3Mw== 1217238 2019-02-08T16:15:11Z 2019-02-08T16:15:11Z MEMBER

@daoudjahdou sorry I missed your comment over in #2304. Threading the new parameter down though other functions is definitely the preferred approach here -- mutating global variables makes it much harder to follow control flow. Though I would probably stop short of modifying maybe_promote and would put this logic inside CFMaskCoder and/or CFScaleOffsetCoder in xarray.coding.variables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   407746874