issue_comments: 460845732

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2277#issuecomment-460845732 https://api.github.com/repos/pydata/xarray/issues/2277 460845732 MDEyOklzc3VlQ29tbWVudDQ2MDg0NTczMg== 2448579 2019-02-05T23:28:39Z 2019-02-05T23:28:39Z MEMBER

For non-numerical hues (or when hue_style='discrete') the legend is turned off by add_legend=False but for numerical ones by add_colorbar=False, which might be not intuitive and might require manual editing in various places if you change your mind between a discrete and continuous legend. I would suggest to either unify both options to one, or make them interchangeable (if not contradicting).

I'm not sure about this. Legends and colorbars are different and the DataArray.plot API has both switches: add_legend and add_colorbar.

@pydata/xarray what do you all think?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   340069538