issue_comments: 460506195

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2277#issuecomment-460506195 https://api.github.com/repos/pydata/xarray/issues/2277 460506195 MDEyOklzc3VlQ29tbWVudDQ2MDUwNjE5NQ== 6164157 2019-02-05T04:09:49Z 2019-02-05T04:13:35Z CONTRIBUTOR

This looks great! Thanks @dcherian!

The only comment I have is with respect to the part of the API that specifies whether a legend should be drawn or not. For non-numerical hues (or when hue_style='discrete') the legend is turned off by add_legend=False but for numerical ones by add_colorbar=False, which might be not intuitive and might require manual editing in various places if you change your mind between a discrete and continuous legend. I would suggest to either unify both options to one, or make them interchangeable (if not contradicting).

something like:

python if xor(add_legend, add_colorbar): #decide according to plot type: if it's non-numeric or `hue_style='discrete'` # then use value of add_legend, else use value of add_colorbar elif add_legend or add_colorbar: #plot legend according to current logic

but really there should only be one allowable keyword here I think

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   340069538