issue_comments: 459457428

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/630#issuecomment-459457428 https://api.github.com/repos/pydata/xarray/issues/630 459457428 MDEyOklzc3VlQ29tbWVudDQ1OTQ1NzQyOA== 1217238 2019-01-31T18:40:57Z 2019-01-31T18:40:57Z MEMBER

The original example how gives an error about dim_1 have different size, but you can still reproduce the behavior if you provide explicit labels for dim_1, e.g., ds = Dataset({"a": DataArray(np.zeros((3, 4)))}, {'dim_1': range(4)}) ds["b"] = b = DataArray(np.zeros((3, 3)), {'dim_1': range(3)}) # !!! we implicitly fill the last column with nans. b[0, 0] = 1 print(ds["b"][0, 0]) # ==> prints 0

The copy argument is still a good idea. We could do: - copy=True always copy - copy=None copy if necessary (default) - copy=False never copy (raise if not possible)

(Note that copy=False in align currently means "copy if necessary", so this would be a breaking change if users are setting that explicitly)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   112253425