issue_comments: 458692011
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/2706#issuecomment-458692011 | https://api.github.com/repos/pydata/xarray/issues/2706 | 458692011 | MDEyOklzc3VlQ29tbWVudDQ1ODY5MjAxMQ== | 1197350 | 2019-01-29T20:19:58Z | 2019-01-29T20:19:58Z | MEMBER | Ok, with the example, I can see a bit better how this works. Here is my main concern: there doesn't appear to be any alignment checking between the target dataset and the new data. The only check that happens is whether a variable with the same name already exists in the target store, if so, append is used (rather than creating a new array). What if the coordinates differ? What if the attributes differ? I'm not sure this is a deal-breaker. But we should be very clear about this in the docs. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
402908148 |