issue_comments: 458609172
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/issues/2710#issuecomment-458609172 | https://api.github.com/repos/pydata/xarray/issues/2710 | 458609172 | MDEyOklzc3VlQ29tbWVudDQ1ODYwOTE3Mg== | 10720577 | 2019-01-29T16:32:36Z | 2019-01-29T17:44:25Z | CONTRIBUTOR | Hi, Thanks for replying. I see what you mean about the 2 separate features. Would it be alright if I opened a PR sometime soon that upgraded I would use your suggested API, i.e. not requiring explicit coordinate names -- that makes sense. However, it feels like the dimension kwargs (i.e. the new dimension/dimensions), should be allowed to be given implicit or explicit coordinates, in case the user doesn't want 0-based integer coordinates for the new dimension. For example,
Thank you! Martin |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
403326458 |