home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 458609172

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2710#issuecomment-458609172 https://api.github.com/repos/pydata/xarray/issues/2710 458609172 MDEyOklzc3VlQ29tbWVudDQ1ODYwOTE3Mg== 10720577 2019-01-29T16:32:36Z 2019-01-29T17:44:25Z CONTRIBUTOR

Hi, Thanks for replying. I see what you mean about the 2 separate features.

Would it be alright if I opened a PR sometime soon that upgraded expand_dims to support the inserting/broadcasting dimensions with size > 1 (the first feature)?

I would use your suggested API, i.e. not requiring explicit coordinate names -- that makes sense. However, it feels like the dimension kwargs (i.e. the new dimension/dimensions), should be allowed to be given implicit or explicit coordinates, in case the user doesn't want 0-based integer coordinates for the new dimension. For example, da.expand_dims(a=3) is equivalent to da.expand_dims(a=[0, 1, 2]) but this will also work da.expand_dims(a=['w', 'x', 'y', 'z']) where da is ```

coords = {"b": range(5), "c": range(3)} da = xr.DataArray(np.ones([5, 3]), coords=coords, dims=list(coords.keys())) da <xarray.DataArray (b: 5, c: 3)> array([[1., 1., 1.], [1., 1., 1.], [1., 1., 1.], [1., 1., 1.], [1., 1., 1.]]) Coordinates: * b (b) int64 0 1 2 3 4 * c (c) int64 0 1 2 ```` Does that make sense?

Thank you! Martin

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  403326458
Powered by Datasette · Queries took 1.044ms · About: xarray-datasette