issue_comments: 455788936

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2593#issuecomment-455788936 https://api.github.com/repos/pydata/xarray/issues/2593 455788936 MDEyOklzc3VlQ29tbWVudDQ1NTc4ODkzNg== 8708062 2019-01-19T15:19:01Z 2019-01-19T15:19:01Z CONTRIBUTOR

Ignore my last comment, I made a really silly mistake. I assumed it was a - b instead of b - a for the exact cftime function. 5808 of 5920 tests now pass and the remaining 112 are ignored due to ValueError: "value falls before first bin".

I think writing targeted unit tests are the last thing on the agenda, so I'll get right on that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   387924616