home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 454769553

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2678#issuecomment-454769553 https://api.github.com/repos/pydata/xarray/issues/2678 454769553 MDEyOklzc3VlQ29tbWVudDQ1NDc2OTU1Mw== 1217238 2019-01-16T12:57:03Z 2019-01-16T12:57:03Z MEMBER

This only crept through the tests because merge was forgiving with what it would merge - should we change the arguments to merge in auto_combine to be something like compat='no_conflicts' so that it fails out instead?

We could need compat='equals' to be stricter, but I suspect that some some users do rely on this "no conflicts" behavior.

This might be a good idea for tests, though.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  399389293
Powered by Datasette · Queries took 1.055ms · About: xarray-datasette