issue_comments: 453923654

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2650#issuecomment-453923654 https://api.github.com/repos/pydata/xarray/issues/2650 453923654 MDEyOklzc3VlQ29tbWVudDQ1MzkyMzY1NA== 1217238 2019-01-14T07:58:26Z 2019-01-14T07:58:26Z MEMBER

Does anyone have a view on the canonical way to implement these for Dataset, given potentially only a subset of the variables will have the dimension? Tests fail when naively using apply_ufunc; .reduce looks like it has some functionality for skipping those variables. Or I could do it manually in a couple of lines.

You could probably copy the logic from Dataset.reduce, which simply applies different logic for coordinates (they either get preserved or dropped depending on if they reuse the reduced dimension). That said, if EWM preserves the dimension size/labels you probably don't nee any special logic for coordinates -- see DatasetRolling.reduce as well.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   396084551