issue_comments: 451592518

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2648#issuecomment-451592518 https://api.github.com/repos/pydata/xarray/issues/2648 451592518 MDEyOklzc3VlQ29tbWVudDQ1MTU5MjUxOA== 1217238 2019-01-04T22:51:24Z 2019-01-04T22:51:24Z MEMBER

Is the following statement True or False: "The user should be allowed to explicitly declare that they want the concatenation dimension to be inferred by passing a keyword argument".

This statement is False, but it looks like we have a related bug: we really should be importing _CONCAT_DIM_DEFAULT from xarray.core.combine, because we use identity comparison in that module. Right now this only works by virtue of the accident that identical string literals points to the same variable in CPython.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   396008054