home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 451589152

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1115#issuecomment-451589152 https://api.github.com/repos/pydata/xarray/issues/1115 451589152 MDEyOklzc3VlQ29tbWVudDQ1MTU4OTE1Mg== 5635139 2019-01-04T22:35:15Z 2019-01-04T22:35:15Z MEMBER

@hrishikeshac that looks great! Well done for getting an MVP running.

Do you want to do a PR from this? Should be v close from here.

Others can comment from there. I'd suggest we get something close to this in and iterate from there. How abstract do we want the dimensions to be (i.e. currently we can only pass one dimension in, which is fine, but potentially we could enable multiple).

One nit - no need to use np.sum - that may cause issues with dask arrays - .sum will work fine

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  188996339
Powered by Datasette · Queries took 162.601ms · About: xarray-datasette