home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 451502294

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2647#issuecomment-451502294 https://api.github.com/repos/pydata/xarray/issues/2647 451502294 MDEyOklzc3VlQ29tbWVudDQ1MTUwMjI5NA== 1217238 2019-01-04T16:57:33Z 2019-01-04T16:57:33Z MEMBER

Indeed, this is should definitely be concat_dim is _CONCAT_DIM_DEFAULT for comparing to a sentinel value.

I think this snuck through because NumPy will automatically cast size 1 arrays (of any shape) to booleans :(. We should probably adapt that test to include an explicit dimension of size greater than 1.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  395994055
Powered by Datasette · Queries took 0.759ms · About: xarray-datasette