home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 449737841

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2436#issuecomment-449737841 https://api.github.com/repos/pydata/xarray/issues/2436 449737841 MDEyOklzc3VlQ29tbWVudDQ0OTczNzg0MQ== 35968931 2018-12-24T14:02:57Z 2018-12-24T14:02:57Z MEMBER

If open_mfdataset() is actually dropping the encoding, then this is an issue related to #1614. That's because in open_mfdataset() while the attrs are explicitly set to those of the first supplied dataset, I don't see any similar explicit treatment of the encoding. I think that means the encoding is being set by what happens inside the core of auto_combine(), and is presumably being lost upon some of the concat or merge operations which happen inside auto_combine().

So I think to fix this then either open_mfdataset() should contain explicit treatment of the encoding, or the rules for propagating the encoding through the auto_combine() should be solidified.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  363299007
Powered by Datasette · Queries took 0.565ms · About: xarray-datasette