issue_comments: 449158415

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2612#issuecomment-449158415 https://api.github.com/repos/pydata/xarray/issues/2612 449158415 MDEyOklzc3VlQ29tbWVudDQ0OTE1ODQxNQ== 6815844 2018-12-20T22:38:19Z 2018-12-20T22:39:20Z MEMBER

During writing the test codes, I realized that the default boundary='exact' is a little annoying. It would be rare that the length of the data is exactly a multiple of the window size; we almost always need to type bounary='trim' or the other. I personally think that boundary='pad' is also a good default, as it is a similar behaviour to rolling.

The down side of this is that it can make a uniformly spaced data an inhomogeneously spaced one. It is something what users may not expect. (probably boundary='exact is safer)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   391477755