issue_comments: 448752816

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2621#issuecomment-448752816 https://api.github.com/repos/pydata/xarray/issues/2621 448752816 MDEyOklzc3VlQ29tbWVudDQ0ODc1MjgxNg== 6815844 2018-12-19T21:38:18Z 2018-12-19T21:38:18Z MEMBER

@shoyer

This issue does not matter only in unstack but also in sel (reindex also?). We can do it in both methods for efficiency, but I just prefered to do it in one place for the quick fix.

But what is the good place to do it actually? If we invoke this in sel, it would be again inefficient as this is called every time we did .sel.

Probably the best for the efficiency is to keep a flag for it in PandasIndexAdapter and do it in _get_item_with_mask and get_loc only if flag is raised?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   392535505