issue_comments: 448672237

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2277#issuecomment-448672237 https://api.github.com/repos/pydata/xarray/issues/2277 448672237 MDEyOklzc3VlQ29tbWVudDQ0ODY3MjIzNw== 2448579 2018-12-19T17:10:17Z 2018-12-19T17:11:19Z MEMBER

I think this is ready for a preliminary review.

I've made the following changes:

  1. Add a hue_style kwarg that can be either 'discrete' (for legend) or 'continuous' (colorbar). add_legend, add_colorbar turn on/off displaying the legend/colorbar which is consistent with our existing DataArray.plot API.

    Examples: ds.plot.scatter(x='A', y='B', hue='x', hue_style='discrete') ds.plot.scatter(x='A', y='B', hue='x', hue_style='continuous')

  2. Under the hood, scatter is always used instead of alternating between plot, scatter depending on hue_style.

  3. Everything has been refactored out to plot/dataset_plot.py

Do people like hue_style? Or something else?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   340069538