issue_comments: 448641329

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2618#issuecomment-448641329 https://api.github.com/repos/pydata/xarray/issues/2618 448641329 MDEyOklzc3VlQ29tbWVudDQ0ODY0MTMyOQ== 4806877 2018-12-19T15:45:04Z 2018-12-19T15:45:04Z CONTRIBUTOR

I did as @snowman2 suggested but filled the mask with nans at the end. Since it is now using rasterio directly this should address @fmaussion's concern about nodata (which I think was ending up in the nodatavals attr anyways). I also moved the nodatavals from attrs to encoding when mask==True, but I didn't set it to true by default since I didn't want to break backwards compatibility. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   392361367