issue_comments: 448402521
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/2618#issuecomment-448402521 | https://api.github.com/repos/pydata/xarray/issues/2618 | 448402521 | MDEyOklzc3VlQ29tbWVudDQ0ODQwMjUyMQ== | 8699967 | 2018-12-18T22:54:44Z | 2018-12-18T22:54:44Z | CONTRIBUTOR | @jsignell, this looks like it would work - I like the implementation. Some things I would recommend to add is checks for when the nodata value varies across bands (maybe skip the mask and raise a warning) and when the nodata value is already NaN. Also, you should probably set the nodatavals to NaN if masked to resemble the behavior of xarray elsewhere. I think @fmaussion would be a good reviewer for this PR. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
392361367 |