issue_comments: 443446419

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2553#issuecomment-443446419 https://api.github.com/repos/pydata/xarray/issues/2553 443446419 MDEyOklzc3VlQ29tbWVudDQ0MzQ0NjQxOQ== 1217238 2018-12-01T18:15:30Z 2018-12-01T18:15:30Z MEMBER

Itertoolz is a dask.array dependency that we didn't explicitly declare in xarray (yes, this was sloppy). We should probably just copy the function we use into some utils file inside xarray -- it has a compatible open source license. Or we could rewrite to not need it. On Sat, Dec 1, 2018 at 8:18 AM Tom Nicholas notifications@github.com wrote:

I've fixed the code so it works with python 3.5 & 2.7 (tested on my local machine), but the tests on python 2.7 are still failing because for some reason it can't find the itertoolz module. I tried to fix this by adding toolz an explicit dependency in setup.py but that didn't work either.

However, given that xarray is supposed to be dropping python 2 support at the end of this year (), does this particularly matter?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2553#issuecomment-443437580, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gVaW7quLcUIo1l-l72xh363f7Utks5u0qvvgaJpZM4YX8wE . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   379415229