home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 443437580

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2553#issuecomment-443437580 https://api.github.com/repos/pydata/xarray/issues/2553 443437580 MDEyOklzc3VlQ29tbWVudDQ0MzQzNzU4MA== 35968931 2018-12-01T16:18:54Z 2018-12-01T16:43:05Z MEMBER

I've fixed the code so it works with python 3.5 & 2.7 (tested on my local machine), but the tests on python 2.7 are still failing because for some reason it can't find the itertoolz module. I tried to fix this by adding toolz an explicit dependency in setup.py but that didn't work either.

However, given that xarray is supposed to be dropping python 2 support at the end of this year (https://github.com/pydata/xarray/issues/1830), does this particularly matter?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  379415229
Powered by Datasette · Queries took 0.785ms · About: xarray-datasette