issue_comments: 443420763
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/2571#issuecomment-443420763 | https://api.github.com/repos/pydata/xarray/issues/2571 | 443420763 | MDEyOklzc3VlQ29tbWVudDQ0MzQyMDc2Mw== | 10050469 | 2018-12-01T11:51:50Z | 2018-12-01T11:51:50Z | MEMBER | Thanks! Made the change as requested. Regarding the general design:
I agree - I don't think it is a big deal either. It must also be noted that this might break some code in downstream libraries (including mine) which has built workarounds for this and will now error because the bounds are already decoded. Here also, I'm quite confident that this is an edge case but its worth mentioning. Should I put my what's new in "Breaking changes" instead? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
384004189 |