home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 442557300

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2559#issuecomment-442557300 https://api.github.com/repos/pydata/xarray/issues/2559 442557300 MDEyOklzc3VlQ29tbWVudDQ0MjU1NzMwMA== 1197350 2018-11-28T18:38:23Z 2018-11-28T18:38:23Z MEMBER

Not sure I understand why there are tests failing now. The failing function is test_basic_compute.

https://travis-ci.org/pydata/xarray/jobs/460873430#L7489

At first glance, this does not appear to have anything to do with my PR. The relevant error is: ```

____ test_basic_compute ______________________________ def test_basic_compute(): ds = Dataset({'foo': ('x', range(5)), 'bar': ('x', range(5))}).chunk({'x': 2}) for get in [dask.threaded.get, dask.multiprocessing.get, dask.local.get_sync, None]: with (dask.config.set(scheduler=get) if LooseVersion(dask.__version) >= LooseVersion('0.19.4') else dask.config.set(scheduler=get) if LooseVersion(dask.version) >= LooseVersion('0.18.0') else dask.set_options(get=get)):

          ds.compute()

xarray/tests/test_dask.py:843:


xarray/core/dataset.py:597: in compute return new.load(kwargs) xarray/core/dataset.py:494: in load evaluated_data = da.compute(*lazy_data.values(), kwargs) ../../../miniconda/envs/test_env/lib/python3.6/site-packages/dask/base.py:390: in compute collections=collections) ../../../miniconda/envs/test_env/lib/python3.6/site-packages/dask/base.py:865: in get_scheduler return get_scheduler(scheduler=config.get('scheduler', None))


get = None, scheduler = <function get at 0x7fc31d9ae048>, collections = None cls = None def get_scheduler(get=None, scheduler=None, collections=None, cls=None): """ Get scheduler function

    There are various ways to specify the scheduler to use:

    1.  Passing in get= parameters (deprecated)
    2.  Passing in scheduler= parameters
    3.  Passing these into global confiuration
    4.  Using defaults of a dask collection

    This function centralizes the logic to determine the right scheduler to use
    from those many options
    """
    if get is not None:
        if scheduler is not None:
            raise ValueError("Both get= and scheduler= provided.  Choose one")
        warn_on_get(get)
        return get

    if scheduler is not None:
      if scheduler.lower() in named_schedulers:

E AttributeError: 'function' object has no attribute 'lower' ../../../miniconda/envs/test_env/lib/python3.6/site-packages/dask/base.py:854: AttributeError ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  382497709
Powered by Datasette · Queries took 0.641ms · About: xarray-datasette