issue_comments: 441639494

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2553#issuecomment-441639494 https://api.github.com/repos/pydata/xarray/issues/2553 441639494 MDEyOklzc3VlQ29tbWVudDQ0MTYzOTQ5NA== 35968931 2018-11-26T13:31:11Z 2018-12-01T15:56:36Z MEMBER

This is basically done now - I've implemented everything I wanted to, and included unit tests for the new functionality. I'm also successfully using it in my personal code now.

@shoyer I haven't changed the way the combine function is applied repeatedly to match the implementation in numpy.block(), I think the way I've done it is relatively clear, but let me know if you think it should be refactored.

~~I don't understand why some of the CI tests are failing - all test which run on my machine pass, and the errors in the log seem to come from dask arrays not being loaded, i.e:~~

AssertionError: <xarray.Dataset> Dimensions: (x: 10, y: 8) Dimensions without coordinates: x, y Data variables: foo (x, y) float64 -1.19 0.4476 0.6283 ... -0.09699 -0.2311 -0.6482 <xarray.Dataset> Dimensions: (x: 10, y: 8) Dimensions without coordinates: x, y Data variables: foo (x, y) float64 dask.array<shape=(10, 8), chunksize=(5, 4)>

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   379415229