issue_comments: 437458789

The danger with inspecting user provided functions is that it's pretty fragile, e.g., it fails if you use provide a signature like args, *kwargs (which can happen pretty easily with decorators). Probably the best option is to come up with a new keyword argument to replace "preprocess" and to deprecate the current preprocess (if we can think of another good name). We could also do a deprecation cycle with FutureWarning, but that's pretty painful.

On Fri, Nov 9, 2018 at 12:29 PM Julia Signell notifications@github.com wrote:

Maybe we can inspect the preprocess function like this:

preprocess = lambda a, b: print(a, b)>>> preprocess .code.co_varnames ('a', 'b')

This response is ordered, so the first one can always be ds regardless of its name and then we can look for special names (like filename) in the rest.

From this answer: https://stackoverflow.com/a/4051447/4021797

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/2550#issuecomment-437433736, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1kvSMx83hACWxXD3tOyIHGqyqum8ks5utbtigaJpZM4YVZ1J .