issue_comments: 436498217

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2533#issuecomment-436498217 https://api.github.com/repos/pydata/xarray/issues/2533 436498217 MDEyOklzc3VlQ29tbWVudDQzNjQ5ODIxNw== 1217238 2018-11-07T04:07:59Z 2018-11-07T04:07:59Z MEMBER

Does adding fastpath to skip shape checking in array_wrap work? fastpath=True in both DataArray.array_wrap and Variable.array_wrap didn't seem to break any tests.

I think it would be slightly better to stick with a separate method for xarray's fast-path. __array_wrap__ is a special protocol used by NumPy, so there's always a (unlikely) risk that if we use different arguments in our version it could break in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   376167325