home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 435733418

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2159#issuecomment-435733418 https://api.github.com/repos/pydata/xarray/issues/2159 435733418 MDEyOklzc3VlQ29tbWVudDQzNTczMzQxOA== 1217238 2018-11-05T02:03:00Z 2018-11-05T02:03:00Z MEMBER

This is fine though right? We can do all of this, because it should compartmentalise fairly easily shouldn't it? You end up with logic like:

Yes, this seems totally fine to me.

We don't need to, but I don't think it would be that hard (if the structure above is feasible), and I think it's a common use case. Also there's an argument for putting in special effort to generalize this function as much as possible, because it lowers the barrier to entry for xarray for new users. Though perhaps I'm just biased because it happens to be my use case...

Sure, no opposition from me if you want to do it! 👍

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  324350248
Powered by Datasette · Queries took 0.456ms · About: xarray-datasette