home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 435706762

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2159#issuecomment-435706762 https://api.github.com/repos/pydata/xarray/issues/2159 435706762 MDEyOklzc3VlQ29tbWVudDQzNTcwNjc2Mg== 35968931 2018-11-04T21:10:55Z 2018-11-05T00:56:06Z MEMBER

we probably want to support all permutations of 1/2.

This is fine though right? We can do all of this, because it should compartmentalise fairly easily shouldn't it? You end up with logic like:

```python def auto_combine(ds_sequence, infer_order_from_coords=True, check_alignment=True): if check_alignment: # Check alignment along non-concatenated dimensions (your (2))

if infer_order_from_coords:
    # Use coordinates to determine tile_ID for each dataset in N-D (your (1))
else:
    # Determine tile_IDs by structure of input in N-D (i.e. ordering in list-of-lists)

# Join everything together
return _concat_nd(tile_IDs, ds_sequence)

```

I'm not sure we need to support this yet

We don't need to, but I don't think it would be that hard (if the structure above is feasible), and I think it's a common use case. Also there's an argument for putting in special effort to generalize this function as much as possible, because it lowers the barrier to entry for xarray for new users. Though perhaps I'm just biased because it happens to be my use case...

Also if we know what form the tile_IDs should take then I can write the _concat_nd function now regardless of what happens with the alignment logic.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  324350248
Powered by Datasette · Queries took 0.461ms · About: xarray-datasette