issue_comments: 435544853

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2159#issuecomment-435544853 https://api.github.com/repos/pydata/xarray/issues/2159 435544853 MDEyOklzc3VlQ29tbWVudDQzNTU0NDg1Mw== 1217238 2018-11-03T00:22:46Z 2018-11-03T00:22:46Z MEMBER

@TomNicholas I agree with your steps 1/2/3 for open_mfdataset.

My concern with a single prealigned=True argument is that there are two distinct use-cases: 1. Checking coordinates along the dimension(s) being concatenated to determine the result order 2. Checking coordinates along other non-concatenated dimensions to verify consistency

Currently we always do (2) and never do (1).

We definitely want an option to disable (2) for speed, and also want an option to support (1) (what you propose here). But these are distinct use cases -- we probably want to support all permutations of 1/2.

However this would mean that users wanting to do a multi-dimensional auto_combine on data without monotonic indexes would have to supply their datasets in some way that specifies their desired N-dimensional ordering

I'm not sure we need to support this yet -- it would be enough to have keyword argument for falling back to the existing behavior that only supports 1D concatenation in the order provided.

Also I'm assuming we are not going to provide functionality to handle uneven sub-lists, e.g. [[t1x1, t1x2], [t2x1, t2x2, t2x3]]?

Agreed, not important unless someone really wants/needs it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   324350248