home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 431425504

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2492#issuecomment-431425504 https://api.github.com/repos/pydata/xarray/issues/2492 431425504 MDEyOklzc3VlQ29tbWVudDQzMTQyNTUwNA== 1217238 2018-10-19T16:44:19Z 2018-10-19T16:44:32Z MEMBER

As someone who hasn't opened up a grib file for several years, I'm not in a good position to choose which backend to use by default. For now, I would be inclined to hold off on making a default choice (unless there is a clear consensus among other xarray devs/users) in favor of requiring users to be explicit. This is somewhat inline with the Zen of Python: "In the face of ambiguity, refuse the temptation to guess."

Probably the best user experience would be to raise an informative error suggesting the use of cfgrib or pynio when opening a grib but no engine is specified, e.g., ```

xarray.open_dataset('data.grib') ValueError: cannot open GRIB files without explicitly setting engine='pynio' or engine='cfgrib' in xarray.open_dataset() ```

{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  371514413
Powered by Datasette · Queries took 0.482ms · About: xarray-datasette