issue_comments: 429626716

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2476#issuecomment-429626716 https://api.github.com/repos/pydata/xarray/issues/2476 429626716 MDEyOklzc3VlQ29tbWVudDQyOTYyNjcxNg== 226037 2018-10-14T13:31:46Z 2018-10-25T21:10:36Z MEMBER

@shoyer I added the TestCfGrib class with basic read tests, a test GRIB file and ecCodes / cfgrib to requirements-py36.yml.

Questions: 1. ~~I failed to reach 100% coverage becasue I didn't find the way to test CfGribDataStore.get_dimensions. Any hint?~~ Done. 2. Can /should I test dask and dask.distributed support in the unit tests? How? Any pointers?

It looks like we are very close, what do you think? Shall I move to the documentation?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   368004737